[llvm-commits] [llvm] r118422 - in /llvm/trunk: lib/Target/ARM/ARMAsmPrinter.cpp lib/Target/ARM/ARMBuildAttrs.h test/CodeGen/ARM/2010-10-19-mc-elf-objheader.ll

[Jason Kim]

On Mon, Nov 8, 2010 at 10:37 AM, Anton Korobeynikov
<anton at korobeynikov.info> wrote:
> Hi Jason,
>
>> +    if (CPUString != "generic") {
>> +      if (CPUString == "cortex-a8") {
> This looks pretty gross. Is it possible to generalize stuff somehow?
> E.g. via the mapping of CPU names => supported attributes.

I agree its very gross. I am going to be iterating over this repeatedly.
I don't yet have a clear understanding of the space of cpu/attributes yet.
As I get more familiarized with how GNU/as does things, I will be
refactoring these.


>
> --
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
>