[llvm-commits] [llvm] r117420 - in /llvm/trunk: cmake/modules/ lib/Target/MBlaze/ lib/Target/MBlaze/AsmParser/ lib/Target/MBlaze/Disassembler/
peckw at wesleypeck.com
Wed Oct 27 06:12:19 PDT 2010
No problem, I'll try to be more careful about looking at the spacing in the code I commit. I'll also go through the MicroBlaze backend in the next couple of days and clean it up.
I work on another project simultaneously that uses the other style so I end up mixing the two styles together a lot :(
-- Wesley Peck
On Oct 27, 2010, at 3:38 AM, Anton Korobeynikov wrote:
> Hello Wesley,
>> + // Get the MCInst opcode from the binary instruction and make sure
>> + // that it is a valid instruction.
>> + unsigned opcode = getOPCODE( insn );
>> + if( opcode == UNSUPPORTED )
>> + return false;
> Could you please use the consistent code style in the files? E.g. no
> spaces after "(" and before ")",
> space before "(", etc.
> With best regards, Anton Korobeynikov
> Faculty of Mathematics and Mechanics, Saint Petersburg State University
More information about the llvm-commits