[llvm-commits] [PATCH]: fixing clang Targets.cpp for PPC

[Nathan Whitehorn]

On 10/15/10 10:00, Rafael Espindola wrote:
>> That is true -- I don't know how I missed that. I also put an error in the
>> Darwin64 ABI where bools should be one byte, not four. Here's a new version
>> of the patch. Could you tell me if it looks OK?
>>      
> s/XXX/FIXME/.
>    
Will fix.
> Just checking:
> * bools should be 32 bits on darwin32 and 8 everywhere else.
>    
Yes.
> * va_list is  __builtin_va_list in 64 bits and that struct in 32 bits.
>
>    
__builtin_va_list is char * on all 64-bit systems and 32-bit Darwin, 
otherwise that struct (identical to amd64 varargs).
> If so, could you just add some tests checking for this? Looks good otherwise.
>    
Yes. That is all correct. Thanks for the review!
-Nathan