[llvm-commits] [PATCH]: fixing clang Targets.cpp for PPC

Rafael Espindola espindola at google.com
Fri Oct 15 08:00:39 PDT 2010


> That is true -- I don't know how I missed that. I also put an error in the
> Darwin64 ABI where bools should be one byte, not four. Here's a new version
> of the patch. Could you tell me if it looks OK?

s/XXX/FIXME/.

Just checking:
* bools should be 32 bits on darwin32 and 8 everywhere else.
* va_list is  __builtin_va_list in 64 bits and that struct in 32 bits.

If so, could you just add some tests checking for this? Looks good otherwise.

> -Nathan
>

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list