[llvm-commits] [patch] va_arg for X86-64

[Rafael Espindola]

On 12 October 2010 06:13, David Meyer <pdox at google.com> wrote:
> Hi Dan,
> Here's the updated patch (against r116297). I think I've addressed every
> comment. Visual diff at: http://codereview.chromium.org/3661004
> I did some local testing and fixed two critical bugs. I disabled f80 (it
> doesn't work how I thought), and I fixed a problem with the PHI instruction
> (it was being inserted at the end of endMBB instead of the beginning).
> I'm not familiar with how the test-suite works, which is why I am confused
> about the testing process. I'd like to add some automated testing for this
> new code as part of the suite. I'll take a look at it and figure out how to
> do that.

There are basically two sets of tests. One is what you get when you
run "make check-lit". These are fast and should test one feature.
There is also the test suite which is in a different svn repository
and builds and runs real code.

For this patch you should probably include a test that shows the
expected results of the va_arg instructions in the .ll file. The test
should just run llc and use FileCheck to look for the expected result
in the produced assembly.

> Note that I don't have commit access, so it's all up to you.
> Thanks,
>  - David M

Cheers,
-- 
Rafael Ávila de Espíndola