[llvm-commits] [patch] va_arg for X86-64

David Meyer pdox at google.com
Tue Oct 12 03:13:06 PDT 2010


Hi Dan,

Here's the updated patch (against r116297). I think I've addressed every
comment. Visual diff at: http://codereview.chromium.org/3661004

I did some local testing and fixed two critical bugs. I disabled f80 (it
doesn't work how I thought), and I fixed a problem with the PHI instruction
(it was being inserted at the end of endMBB instead of the beginning).

I'm not familiar with how the test-suite works, which is why I am confused
about the testing process. I'd like to add some automated testing for this
new code as part of the suite. I'll take a look at it and figure out how to
do that.

Note that I don't have commit access, so it's all up to you.

Thanks,
 - David M
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101012/f359b3a9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vaarg-x86-64-two.patch
Type: application/octet-stream
Size: 18736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20101012/f359b3a9/attachment.obj>


More information about the llvm-commits mailing list