[llvm-commits] [llvm] r109739 - in /llvm/trunk/tools/llvm-diff: ./ CMakeLists.txt DifferenceEngine.cpp DifferenceEngine.h Makefile llvm-diff.cpp

[Chris Lattner]

On Jul 29, 2010, at 12:53 AM, John McCall wrote:

> Author: rjmccall
> Date: Thu Jul 29 02:53:27 2010
> New Revision: 109739
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=109739&view=rev
> Log:
> Add the llvm-diff tool, which performs a relatively naive structural
> diff of a function.  There's a lot of cruft in the current version, and
> it's pretty far from perfect, but it's usable.
> 
> Currently only capable of comparing functions.  Currently ignores metadata.
> Currently ignores most attributes of functions and instructions.

Nifty!  I hope to have a chance to look at this more in detail later, but two comments.

1. Please use the CommandLine library instead of rolling your own option processing:
http://llvm.org/docs/CommandLine.html

2. Please follow the LLVM #include conventions:
http://llvm.org/docs/CodingStandards.html#scf_includes

Apparently not mentioned there, but please use "llvm/x" and not <llvm/x> when inside the llvm code base.

Thanks John!

-Chris