[llvm-commits] [llvm] r109739 - in /llvm/trunk/tools/llvm-diff: ./ CMakeLists.txt DifferenceEngine.cpp DifferenceEngine.h Makefile llvm-diff.cpp

[John McCall]

On Jul 29, 2010, at 10:02 AM, Devang Patel wrote:
>> +  bool diff(Instruction *L, Instruction *R, bool Complain, bool TryUnify) {
> 
> Any reason to not directly use one of the following Instruction methods here ?

I can't use the isIdenticalTo methods because I have to use my own rules for
operand equality.  I didn't know about isSameOperationAs, but I suspect I still
don't want to use it because I don't want to consider (say) an inbounds GEP to
be structurally different from an undecorated one:  I'd rather match them and then
point out the difference.

John.