[llvm-commits] [llvm] r108816 - in /llvm/trunk: lib/Target/Mips/MipsISelLowering.cpp test/CodeGen/Mips/2010-07-20-Select.ll

[Jakob Stoklund Olesen]

On Jul 20, 2010, at 12:58 AM, Bruno Cardoso Lopes wrote:

> Author: bruno
> Date: Tue Jul 20 02:58:51 2010
> New Revision: 108816
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=108816&view=rev
> Log:
> Fix Mips PR7473. Patch by stetorvs at gmail.com
> 
> Added:
>    llvm/trunk/test/CodeGen/Mips/2010-07-20-Select.ll
> Modified:
>    llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
> 
> Modified: llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp?rev=108816&r1=108815&r2=108816&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/MipsISelLowering.cpp Tue Jul 20 02:58:51 2010
> @@ -317,13 +317,13 @@
>     BB->addSuccessor(sinkMBB);
> 
>     //  sinkMBB:
> -    //   %Result = phi [ %FalseValue, copy0MBB ], [ %TrueValue, thisMBB ]
> +    //   %Result = phi [ %TrueValue, thisMBB ], [ %FalseValue, copy0MBB ]
>     //  ...
>     BB = sinkMBB;
>     BuildMI(*BB, BB->begin(), dl,
>             TII->get(Mips::PHI), MI->getOperand(0).getReg())
> -      .addReg(MI->getOperand(2).getReg()).addMBB(copy0MBB)
> -      .addReg(MI->getOperand(3).getReg()).addMBB(thisMBB);
> +      .addReg(MI->getOperand(2).getReg()).addMBB(thisMBB)
> +      .addReg(MI->getOperand(3).getReg()).addMBB(copy0MBB);
> 
>     MI->eraseFromParent();   // The pseudo instruction is gone now.
>     return BB;

Hi Bruno,

The change to the comment doesn't match the change to the code. Was that on purpose?

/jakob