[llvm-commits] [patch] Remove arm_aapcscc from some tests

Bob Wilson bob.wilson at apple.com
Tue Jun 15 12:01:36 PDT 2010


On Jun 15, 2010, at 11:48 AM, Rafael Espindola wrote:

>> This isn't really necessary, is it?  It's still OK to explicitly specify the calling convention, right?  Are you just trying to get better test coverage for using the default ABI?
> 
> Correct. Since I intend to switch the FE, it is better if most tests
> have the same structure as the output of the FE.
> 
>> What's the default ABI for "-mtriple=armv6-elf" or "-march=arm"?  It isn't obvious to me whether those should use APCS or AAPCS, so maybe it is better to explicitly specify the CC in those cases.
> 
> None of those tests was checking anything specific about the ABI. For
> tests that do, it is probably better to pass a more complete mtriple,
> no?

I guess so.  I don't have any objections to your change as long as it doesn't break the tests.



More information about the llvm-commits mailing list