[llvm-commits] [patch] Remove arm_aapcscc from some tests

Rafael Espindola espindola at google.com
Tue Jun 15 11:48:19 PDT 2010


> This isn't really necessary, is it?  It's still OK to explicitly specify the calling convention, right?  Are you just trying to get better test coverage for using the default ABI?

Correct. Since I intend to switch the FE, it is better if most tests
have the same structure as the output of the FE.

> What's the default ABI for "-mtriple=armv6-elf" or "-march=arm"?  It isn't obvious to me whether those should use APCS or AAPCS, so maybe it is better to explicitly specify the CC in those cases.

None of those tests was checking anything specific about the ABI. For
tests that do, it is probably better to pass a more complete mtriple,
no?

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list