[llvm-commits] inital AVX instructions support!

[Eric Christopher]

Hi Bruno,

On Jun 2, 2010, at 6:30 PM, Bruno Cardoso Lopes wrote:

> This patch introduces initial support to AVX instructions. Some issues:
> 
> - The enums for prefix opcodes and other stuff in X86II occupy all the
> 32 bit space, so the
> only AVX opcode created so far overlaps this space, and is handled
> specially during encoding. This also required increasing the TSFlags to
> 64 bits.
> - More refactoring can still be done with SSE instructions, and more
> opportunities should arise with the new AVX stuff.
> - This patch follows the path "encode before matching", so the few
> instructions added, and those which are about to come could be
> assembled but not matched yet.


Looks like a good start.  One comment and a few questions:

a) Might be nice if you could split out the 64-bit-izing of TSFlags?

b) From the REX prefix I see R, B and W - what about X?

c) you mention 0b01 for 0x66, but I don't see it in the prefix?  Handled somewhere else I imagine?

d) can you make the FIXME for register handling a bit more descriptive of what needs to happen?

e) furute->future :)

Thanks!

-eric