[llvm-commits] [patch] Remove the TargetRegisterClass from CalleeSavedInfo

Jakob Stoklund Olesen stoklund at 2pi.dk
Wed Jun 2 12:48:12 PDT 2010

On Jun 2, 2010, at 12:37 PM, Rafael Espindola wrote:

>> This kind of thing is usually not what you want. Please do as you did for ARM: Mips::CPURegsRegisterClass->contains(Reg)
>> Same issue with the PPC and SystemZ changes. As a general rule it is a mistake to test register class identity. You almost always want "is register in", or "is a subclass of" comparisons.
> Good point. An updated patch is attached.

Looks good.

More information about the llvm-commits mailing list