[llvm-commits] [patch] Remove the TargetRegisterClass from CalleeSavedInfo

Rafael Espindola espindola at google.com
Wed Jun 2 12:37:58 PDT 2010

> This kind of thing is usually not what you want. Please do as you did for ARM: Mips::CPURegsRegisterClass->contains(Reg)
> Same issue with the PPC and SystemZ changes. As a general rule it is a mistake to test register class identity. You almost always want "is register in", or "is a subclass of" comparisons.

Good point. An updated patch is attached.

> /jakob

Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CalleeSavedInfo.patch
Type: text/x-diff
Size: 18035 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100602/d9c8ae1f/attachment.patch>

More information about the llvm-commits mailing list