[llvm-commits] [llvm] r103828 - /llvm/trunk/lib/CodeGen/RegAllocFast.cpp

Chandler Carruth chandlerc at google.com
Sat May 15 03:28:11 PDT 2010


On Fri, May 14, 2010 at 3:02 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:
>
>
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/RegAllocFast.cpp (original)
> +++ llvm/trunk/lib/CodeGen/RegAllocFast.cpp Fri May 14 17:02:56 2010
> @@ -394,7 +394,8 @@
>
>   // Ignore invalid hints.
>   if (Hint && (!TargetRegisterInfo::isPhysicalRegister(Hint) ||
> -               !RC->contains(Hint) || UsedInInstr.test(Hint)))
> +               !RC->contains(Hint) || UsedInInstr.test(Hint)) ||
> +               !Allocatable.test(Hint))
>

I think the !Allocatable.test(Hint) is intended to be in the group of ||s?
Every other use groups in that way, the indentation agrees, and a GCC
warning pointed this out, so I went ahead and switch it in r103869. Please
review, and I'll fix if this was intentional (and you don't beat me to it!).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100515/bd0895c4/attachment.html>


More information about the llvm-commits mailing list