[llvm-commits] MCSectionCOFF patch

Chris Lattner clattner at apple.com
Fri May 7 14:50:28 PDT 2010

On May 7, 2010, at 1:16 PM, Nathan Jeffords wrote:

> here is my additional changes to MCSectionCOFF, mostly it adds support for COMDAT sections, but I also renamed Flags to Characteristics <TLOF.patch>

Looks fine to me (though again, I'm not a COFF knowledgable person), committed in r103304.

RE this comment:
+    //FIXME: all COFF enumerations/flags should be standardized into one place...
+    // Target/X86COFF.h doesn't seem right as COFF can be used for other targets,
+    // MC/WinCOFF.h maybe right as it isn't target or entity specific, and it is
+    //   pretty low on the dependancy graph (is there any need to support non
+    //   windows COFF?)

It would make sense to put it in llvm/include/Support/COFF.h.  We already have an ELF.h, Dwarf.h etc in that directory.  While it might not be the best place long term, it is good to be consistent.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100507/d50fba2f/attachment.html>

More information about the llvm-commits mailing list