<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 7, 2010, at 1:16 PM, Nathan Jeffords wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">here is my additional changes to MCSectionCOFF, mostly it adds support for COMDAT sections, but I also renamed Flags to Characteristics
<span><TLOF.patch></span></blockquote></div><br><div>Looks fine to me (though again, I'm not a COFF knowledgable person), committed in r103304.</div><div><br></div><div>RE this comment:</div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ //FIXME: all COFF enumerations/flags should be standardized into one place...</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ // Target/X86COFF.h doesn't seem right as COFF can be used for other targets,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ // MC/WinCOFF.h maybe right as it isn't target or entity specific, and it is</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ // pretty low on the dependancy graph (is there any need to support non</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 12px/normal Inconsolata; ">+ // windows COFF?)</div><div><font class="Apple-style-span" face="Inconsolata"><br></font></div><div><font class="Apple-style-span" face="Inconsolata">It would make sense to put it in llvm/include/Support/COFF.h. We already have an ELF.h, Dwarf.h etc in that directory. While it might not be the best place long term, it is good to be consistent.</font></div><div><font class="Apple-style-span" face="Inconsolata"><br></font></div><div><font class="Apple-style-span" face="Inconsolata">-Chris</font></div></div><div><br></div></body></html>