[llvm-commits] [llvm] r98120 - /llvm/trunk/lib/MC/MCAssembler.cpp

[Daniel Dunbar]

Author: ddunbar
Date: Tue Mar  9 20:10:29 2010
New Revision: 98120

URL: http://llvm.org/viewvc/llvm-project?rev=98120&view=rev
Log:
MC/Mach-O: Resolve a FIXME; these relocation types are no longer semanticaly different.

Modified:
    llvm/trunk/lib/MC/MCAssembler.cpp

Modified: llvm/trunk/lib/MC/MCAssembler.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCAssembler.cpp?rev=98120&r1=98119&r2=98120&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCAssembler.cpp (original)
+++ llvm/trunk/lib/MC/MCAssembler.cpp Tue Mar  9 20:10:29 2010
@@ -462,9 +462,11 @@
         llvm_report_error("symbol '" + B->getName() +
                           "' can not be undefined in a subtraction expression");
 
-      // FIXME: This change of type based on the external bit doesn't make much
-      // sense, it seems to be redundant with the other information in the
-      // relocation entry.
+      // Select the appropriate difference relocation type.
+      //
+      // Note that there is no longer any semantic difference between these two
+      // relocation types from the linkers point of view, this is done solely
+      // for pedantic compatibility with 'as'.
       Type = A_SD->isExternal() ? RIT_Difference : RIT_LocalDifference;
       Value2 = B_SD->getFragment()->getAddress() + B_SD->getOffset();
     }