[llvm-commits] [llvm] r96956 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[David Greene]

On Tuesday 23 February 2010 16:46:51 Chris Lattner wrote:

> > Again, this is with debugging enabled, and extra checks on top of that. 
> > Stuff is SLLOOOWW anyway.  :)
>
> Please fix it anyway.  Also, please close:

Ok, but realize there is a debugging consequence.  Every time we replace
a standard data structure with a nonstandard one, we lose the benefit of
the libstdc++ debugging mode checks.  Generally, my preference is to not
optimize unless proven to need so by profiling.

But like I said, I'll change it.

Actually, one of my long-term TODO things is to get the custom data structures
standard-confoming enough that we could replace them with standard components
in Debug+Checks mode to get maximal debug checking.

> http://llvm.org/bugs/show_bug.cgi?id=6405 if have addressed this problem. 
> People do actually care about the speed of checking enabled builds.

Yep, it's the same issue.   This is an extreme case.  Using a std::set isn't 
nearly in the same class.

                                          -Dave