[llvm-commits] [llvm] r96956 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

[Chris Lattner]

On Feb 23, 2010, at 1:05 PM, David Greene wrote:

> On Tuesday 23 February 2010 11:41:28 Chris Lattner wrote:
>> On Feb 23, 2010, at 9:37 AM, David Greene wrote:
>>> Author: greened
>>> Date: Tue Feb 23 11:37:50 2010
>>> New Revision: 96956
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=96956&view=rev
>>> Log:
>>> 
>>> Speed up cycle checking significantly by caching results.
>> 
>> Please use a SmallPtrSet instead of std::set, it is much faster for
>> pointers.
> 
> Again, this is with debugging enabled, and extra checks on top of that.  Stuff 
> is SLLOOOWW anyway.  :)

Please fix it anyway.  Also, please close http://llvm.org/bugs/show_bug.cgi?id=6405 if have addressed this problem.  People do actually care about the speed of checking enabled builds.

-Chris