[llvm-commits] [llvm-gcc][patch] Merge SVR4ABI and DefaultABI

Rafael Espindola espindola at google.com
Mon Feb 15 13:17:37 PST 2010


> It won't change anything  on non-ppc, for sure.  I'm not so sure about
> Darwin ppc.  I'd expect we need
>
> +#define LLVM_TRY_PASS_AGGREGATE_CUSTOM(T, E, CC, C)    \
> +  false
>
> in rs6000/darwin.h.  Does that look right?  I'll give it a try.


I don't think it is necessary as llvm_rs6000_try_pass_aggregate_custom
starts with

 if (!isSVR4ABI())
    return false;

and isSVR4ABI is defined as

static bool isSVR4ABI() {
#if defined(POWERPC_LINUX) && (TARGET_64BIT == 0)
  return true;
#else
  return false;
#endif
}

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list