[llvm-commits] [llvm-gcc][patch] Merge SVR4ABI and DefaultABI

[Dale Johannesen]

On Feb 15, 2010, at 1:00 PMPST, Rafael Espindola wrote:

> The attached patch merges the two implementations of the ABI. It moves
> the ppc specific code to the config/rs6000 directory and adds the
> macro LLVM_TRY_PASS_AGGREGATE_CUSTOM to access it. It is a nop for non
> linux ppc since that macro is defined to false by default.
>
> I tested that llvm-gcc bootstraps on x86_64 linux and that a llvm-gcc
> targeting ppc linux uses llvm_rs6000_try_pass_aggregate_custom.
>
> Is it OK?

It won't change anything  on non-ppc, for sure.  I'm not so sure about  
Darwin ppc.  I'd expect we need

+#define LLVM_TRY_PASS_AGGREGATE_CUSTOM(T, E, CC, C)	\
+  false

in rs6000/darwin.h.  Does that look right?  I'll give it a try.

> 8 files changed, 134 insertions(+), 497 deletions(-)
>
> Cheers,
> -- 
> Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: merge.patch
Type: text/x-diff
Size: 26971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100215/1532a919/attachment.patch>
-------------- next part --------------
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits