[llvm-commits] [llvm] r83207 - /llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp

[Devang Patel]

On Jan 15, 2010, at 2:51 PM, Chris Lattner wrote:

>> On Jan 4, 2010, at 10:59 AM, Chris Lattner wrote:
>> 
>>> 
>>> On Jan 4, 2010, at 8:55 AM, Devang Patel wrote:
>>> 
>>>> 
>>>> On Jan 3, 2010, at 9:22 PM, Chris Lattner wrote:
>>>> 
>>>>> On Oct 1, 2009, at 2:35 PM, Evan Cheng wrote:
>>>>>> Can't we compute these on demand so codegen passes don't have to change these?
>>>>> 
>>>>> Devang, I never saw an answer to this.  
>>>> 
>>>> Now, we compute this just before asmprint.
>>> 
>>> DbgScope still maintains these as instance variables.  I see that it is now an asmprinter local data structure, so we can't have pointer invalidation issues.  However, we still have memory use to consider.
>>>  
>>>>> I have serious concerns about DbgScope and the presence of two MachineInstr*'s that can dangle seems very dubious.
>>>> 
>>>> DbgScope is representing lexical scopes for debug info.
>>> 
>>> How many DbgScopes are created?

One for each lexical scope identified by FE.
-
Devang

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100115/8e8e9c31/attachment.html>