<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 15, 2010, at 2:51 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jan 4, 2010, at 10:59 AM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 4, 2010, at 8:55 AM, Devang Patel wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jan 3, 2010, at 9:22 PM, Chris Lattner wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Oct 1, 2009, at 2:35 PM, Evan Cheng wrote:</div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Can't we compute these on demand so codegen passes don't have to change these?</div></blockquote><div><br></div>Devang, I never saw an answer to this. </div></div></blockquote><div><br></div><div>Now, we compute this just before asmprint.</div></div></div></blockquote><div><br></div>DbgScope still maintains these as instance variables. I see that it is now an asmprinter local data structure, so we can't have pointer invalidation issues. However, we still have memory use to consider.</div><div> <br><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I have serious concerns about <span class="Apple-style-span" style="font-family: monospace; ">DbgScope and the presence of two MachineInstr*'s that can dangle seems very dubious.</span></div></div></blockquote><div><br></div><div>DbgScope is representing lexical scopes for debug info.</div></div></div></blockquote><div><br></div><div>How many DbgScopes are created?</div></div></div></blockquote></div></div></blockquote></span></blockquote><br></div><div>One for each lexical scope identified by FE.</div><div>-</div><div>Devang</div><br></body></html>