[llvm-commits] [patch] fptr support for PPC64

[Tilmann Scheller]

Hi Ken,

I've committed the function pointer and the frame pointer save offset
patches (I added a few more comments, no change in functionality). As
Dale suggested, I also added an isPPC64 parameter to the static
function.

Thanks for working on this!

Greetings,

Tilmann

On Thu, Dec 17, 2009 at 1:28 PM, Ken Werner <ken at linux.vnet.ibm.com> wrote:
> On Thursday 17 December 2009 02:22:22 am you wrote:
>> >> It's preferable to get isPPC64 from PPCSubTarget, as elsewhere
>> >> (inconsistently).  Here that seems to mean an extra parameter.
>> >> Why did you add a Chain to PPCISD::NOP?
>> >> Do you have write access?
>> >
>> > The upated version of the patch obtains isPPC64 from PPCSubTarget
>>
>> Um, no, you changed one of the existing places where it was obtained
>> otherwise (which is fine), but not the place you added it.
>>
> Whoops, my bad.
> What is the preferred way to get PPCSubTarget from a static method?
> Thanks
> -ken
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>