[llvm-commits] [patch] fptr support for PPC64

Ken Werner ken at linux.vnet.ibm.com
Thu Dec 17 04:28:06 PST 2009


On Thursday 17 December 2009 02:22:22 am you wrote:
> >> It's preferable to get isPPC64 from PPCSubTarget, as elsewhere
> >> (inconsistently).  Here that seems to mean an extra parameter.
> >> Why did you add a Chain to PPCISD::NOP?
> >> Do you have write access?
> >
> > The upated version of the patch obtains isPPC64 from PPCSubTarget
> 
> Um, no, you changed one of the existing places where it was obtained
> otherwise (which is fine), but not the place you added it.
> 
Whoops, my bad. 
What is the preferred way to get PPCSubTarget from a static method?
Thanks
-ken



More information about the llvm-commits mailing list