[llvm-commits] [llvm] r91273 - in /llvm/trunk: include/llvm/CodeGen/CalcSpillWeights.h lib/CodeGen/CalcSpillWeights.cpp lib/CodeGen/PreAllocSplitting.cpp lib/CodeGen/RegAllocLinearScan.cpp lib/CodeGen/RegAllocPBQP.cpp lib/CodeGen/SimpleRegisterCoalescing.cpp lib/CodeGen/SimpleRegisterCoalescing.h

[Jakob Stoklund Olesen]

On Dec 13, 2009, at 10:49 PM, Lang Hames wrote:

> Author: lhames
> Date: Mon Dec 14 00:49:42 2009
> New Revision: 91273
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=91273&view=rev
> Log:
> Moved spill weight calculation out of SimpleRegisterCoalescing and into its own pass: CalculateSpillWeights.

Very nice! I was wondering what that method was doing in the coalescer.

> ==============================================================================
> --- llvm/trunk/include/llvm/CodeGen/CalcSpillWeights.h (added)
> +++ llvm/trunk/include/llvm/CodeGen/CalcSpillWeights.h Mon Dec 14 00:49:42 2009

I think you can do without the header file. Just put a CalculateSpillWeightsID in Passes.h instead.

> +/// Returns true if the given live interval is zero length.
> +bool CalculateSpillWeights::isZeroLengthInterval(LiveInterval *li) const {

Should this be a method on LiveInterval instead?

/jakob

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 1929 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091214/b8f1c7e5/attachment.bin>