[llvm-commits] [llvm] r89156 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/Analysis/DebugInfo.cpp

[Jeffrey Yasskin]

On Fri, Nov 20, 2009 at 9:22 AM, Devang Patel <dpatel at apple.com> wrote:
>
> On Nov 20, 2009, at 8:53 AM, Jeffrey Yasskin wrote:
>
>> They weren't quite dead: I was calling them. :)
>
> oops. I didn't realize. Feel free to bring this back for short term while
> you update your client.

Well, I assume the intrinsics they insert no longer actually do what
they used to do, and so I should replace them with something. I just
want to know what to replace them with. I figured out that
InsertStopPoint turned into
        IRBuilder::SetCurrentDebugLocation(
            DIFactory::CreateLocation(line_number, col_number,
                                              DISubprogram,
                                              DILocation(NULL)).getNode());
(is DILocation(NULL) really the best way to anchor the DILocation chain?)

But I can't find what to replace InsertSubprogramStart and
InsertRegionEnd with. Did they just go away? Did they go away
temporarily until llvm.dbg.var is ready?

I'm updating Unladen Swallow as I merge from llvm head, so I'd rather
change it now than have to commit to LLVM and re-merge.

>> Could you update
>> http://llvm.org/docs/SourceLevelDebugging.html to describe the new
>> state of the world and how to upgrade?
>
> I was waiting for Victor to finish up llvm.dbg.var work before updating
> document, because this is still a work in progress. But since someone is
> reading docs for mainline, I'll do a quick pass sooner :)

Thanks!
Jeffrey