[llvm-commits] [llvm] r89156 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/Analysis/DebugInfo.cpp

[Devang Patel]

On Nov 20, 2009, at 8:53 AM, Jeffrey Yasskin wrote:

> They weren't quite dead: I was calling them. :)

oops. I didn't realize. Feel free to bring this back for short term  
while you update your client.

> Could you update
> http://llvm.org/docs/SourceLevelDebugging.html to describe the new
> state of the world and how to upgrade?

I was waiting for Victor to finish up llvm.dbg.var work before  
updating document, because this is still a work in progress. But since  
someone is reading docs for mainline, I'll do a quick pass sooner :)
-
Devang

>
> On Tue, Nov 17, 2009 at 2:39 PM, Devang Patel <dpatel at apple.com>  
> wrote:
>> Author: dpatel
>> Date: Tue Nov 17 16:39:08 2009
>> New Revision: 89156
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=89156&view=rev
>> Log:
>> Remove dead code.
>>
>> Modified:
>>    llvm/trunk/include/llvm/Analysis/DebugInfo.h
>>    llvm/trunk/lib/Analysis/DebugInfo.cpp
>>
>> Modified: llvm/trunk/include/llvm/Analysis/DebugInfo.h
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Analysis/DebugInfo.h?rev=89156&r1=89155&r2=89156&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm/trunk/include/llvm/Analysis/DebugInfo.h (original)
>> +++ llvm/trunk/include/llvm/Analysis/DebugInfo.h Tue Nov 17  
>> 16:39:08 2009
>> @@ -468,15 +468,8 @@
>>     Module &M;
>>     LLVMContext& VMContext;
>>
>> -    // Cached values for uniquing and faster lookups.
>>     const Type *EmptyStructPtr; // "{}*".
>> -    Function *StopPointFn;   // llvm.dbg.stoppoint
>> -    Function *FuncStartFn;   // llvm.dbg.func.start
>> -    Function *RegionStartFn; // llvm.dbg.region.start
>> -    Function *RegionEndFn;   // llvm.dbg.region.end
>>     Function *DeclareFn;     // llvm.dbg.declare
>> -    StringMap<Constant*> StringCache;
>> -    DenseMap<Constant*, DIDescriptor> SimpleConstantCache;
>>
>>     DIFactory(const DIFactory &);     // DO NOT IMPLEMENT
>>     void operator=(const DIFactory&); // DO NOT IMPLEMENT
>> @@ -605,23 +598,6 @@
>>     DILocation CreateLocation(unsigned LineNo, unsigned ColumnNo,
>>                               DIScope S, DILocation OrigLoc);
>>
>> -    /// InsertStopPoint - Create a new llvm.dbg.stoppoint  
>> intrinsic invocation,
>> -    /// inserting it at the end of the specified basic block.
>> -    void InsertStopPoint(DICompileUnit CU, unsigned LineNo,  
>> unsigned ColNo,
>> -                         BasicBlock *BB);
>> -
>> -    /// InsertSubprogramStart - Create a new llvm.dbg.func.start  
>> intrinsic to
>> -    /// mark the start of the specified subprogram.
>> -    void InsertSubprogramStart(DISubprogram SP, BasicBlock *BB);
>> -
>> -    /// InsertRegionStart - Insert a new llvm.dbg.region.start  
>> intrinsic call to
>> -    /// mark the start of a region for the specified scoping  
>> descriptor.
>> -    void InsertRegionStart(DIDescriptor D, BasicBlock *BB);
>> -
>> -    /// InsertRegionEnd - Insert a new llvm.dbg.region.end  
>> intrinsic call to
>> -    /// mark the end of a region for the specified scoping  
>> descriptor.
>> -    void InsertRegionEnd(DIDescriptor D, BasicBlock *BB);
>> -
>>     /// InsertDeclare - Insert a new llvm.dbg.declare intrinsic call.
>>     Instruction *InsertDeclare(llvm::Value *Storage, DIVariable D,
>>                                BasicBlock *InsertAtEnd);
>>
>> Modified: llvm/trunk/lib/Analysis/DebugInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/DebugInfo.cpp?rev=89156&r1=89155&r2=89156&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm/trunk/lib/Analysis/DebugInfo.cpp (original)
>> +++ llvm/trunk/lib/Analysis/DebugInfo.cpp Tue Nov 17 16:39:08 2009
>> @@ -606,9 +606,7 @@
>>  // 
>> = 
>> = 
>> = 
>> ----------------------------------------------------------------------= 
>> ==//
>>
>>  DIFactory::DIFactory(Module &m)
>> -  : M(m), VMContext(M.getContext()), StopPointFn(0), FuncStartFn(0),
>> -    RegionStartFn(0), RegionEndFn(0),
>> -    DeclareFn(0) {
>> +  : M(m), VMContext(M.getContext()), DeclareFn(0) {
>>   EmptyStructPtr =  
>> PointerType::getUnqual(StructType::get(VMContext));
>>  }
>>
>> @@ -983,58 +981,6 @@
>>  // DIFactory: Routines for inserting code into a function
>>  // 
>> = 
>> = 
>> = 
>> ----------------------------------------------------------------------= 
>> ==//
>>
>> -/// InsertStopPoint - Create a new llvm.dbg.stoppoint intrinsic  
>> invocation,
>> -/// inserting it at the end of the specified basic block.
>> -void DIFactory::InsertStopPoint(DICompileUnit CU, unsigned LineNo,
>> -                                unsigned ColNo, BasicBlock *BB) {
>> -
>> -  // Lazily construct llvm.dbg.stoppoint function.
>> -  if (!StopPointFn)
>> -    StopPointFn = llvm::Intrinsic::getDeclaration(&M,
>> -                                               
>> llvm::Intrinsic::dbg_stoppoint);
>> -
>> -  // Invoke llvm.dbg.stoppoint
>> -  Value *Args[] = {
>> -    ConstantInt::get(llvm::Type::getInt32Ty(VMContext), LineNo),
>> -    ConstantInt::get(llvm::Type::getInt32Ty(VMContext), ColNo),
>> -    CU.getNode()
>> -  };
>> -  CallInst::Create(StopPointFn, Args, Args+3, "", BB);
>> -}
>> -
>> -/// InsertSubprogramStart - Create a new llvm.dbg.func.start  
>> intrinsic to
>> -/// mark the start of the specified subprogram.
>> -void DIFactory::InsertSubprogramStart(DISubprogram SP, BasicBlock  
>> *BB) {
>> -  // Lazily construct llvm.dbg.func.start.
>> -  if (!FuncStartFn)
>> -    FuncStartFn = Intrinsic::getDeclaration(&M,  
>> Intrinsic::dbg_func_start);
>> -
>> -  // Call llvm.dbg.func.start which also implicitly sets a  
>> stoppoint.
>> -  CallInst::Create(FuncStartFn, SP.getNode(), "", BB);
>> -}
>> -
>> -/// InsertRegionStart - Insert a new llvm.dbg.region.start  
>> intrinsic call to
>> -/// mark the start of a region for the specified scoping descriptor.
>> -void DIFactory::InsertRegionStart(DIDescriptor D, BasicBlock *BB) {
>> -  // Lazily construct llvm.dbg.region.start function.
>> -  if (!RegionStartFn)
>> -    RegionStartFn = Intrinsic::getDeclaration(&M,  
>> Intrinsic::dbg_region_start);
>> -
>> -  // Call llvm.dbg.func.start.
>> -  CallInst::Create(RegionStartFn, D.getNode(), "", BB);
>> -}
>> -
>> -/// InsertRegionEnd - Insert a new llvm.dbg.region.end intrinsic  
>> call to
>> -/// mark the end of a region for the specified scoping descriptor.
>> -void DIFactory::InsertRegionEnd(DIDescriptor D, BasicBlock *BB) {
>> -  // Lazily construct llvm.dbg.region.end function.
>> -  if (!RegionEndFn)
>> -    RegionEndFn = Intrinsic::getDeclaration(&M,  
>> Intrinsic::dbg_region_end);
>> -
>> -  // Call llvm.dbg.region.end.
>> -  CallInst::Create(RegionEndFn, D.getNode(), "", BB);
>> -}
>> -
>>  /// InsertDeclare - Insert a new llvm.dbg.declare intrinsic call.
>>  Instruction *DIFactory::InsertDeclare(Value *Storage, DIVariable D,
>>                               Instruction *InsertBefore) {
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>