[llvm-commits] [PATCH] LTO code generator options

[Viktor Kutuzov]

Thanks, Nick and Rafael!

> Two t's in formatted.

Fixed.

>> You have to change the .c_str() to llvm::Triple().

Fixed.

Patch is committed.
http://llvm.org/viewvc/llvm-project?rev=89236&view=rev

And while we are all on it, here is the next patch in this sequence (please find it attached).

This patch adds two SubtargetFeatures::AddFeatures methods which accept a comma-separated string or already parsed command line parameters as input, SubtargetFeatures::hasFeature method which cheks if given feature is already set, and some code re-factoring to use these new methods.

Best regards,
Viktor

  ----- Original Message ----- 
  From: Nick Lewycky 
  To: Rafael Espindola 
  Cc: Viktor Kutuzov ; Commit Messages and Patches for LLVM 
  Sent: Wednesday, November 18, 2009 10:34 AM
  Subject: Re: [llvm-commits] [PATCH] LTO code generator options


  +  /// Retrieve a formated string of the default features for
  +  /// the specified target triple.
  +  static std::string getDefaultSubtargetFeatures(const Triple &Triple);

  Two t's in formatted.

  2009/11/18 Rafael Espindola <espindola at google.com>

    2009/11/17 Viktor Kutuzov <vkutuzov at accesssoftek.com>:

    > Thanks for reviewing it, Rafael.
    >
    > Now while we are both on the same waive, let's go with the rest of the patches.


    Have you committed the previous one?


    > I have tried to combine them on the same manner as the last one.


    Thanks!

    You have

    +        const std::string FeatureStr =
    +            SubtargetFeatures::getDefaultSubtargetFeatures(Triple.c_str());

    But getDefaultSubtargetFeatures takes a triple. You have to change the
    .c_str() to llvm::Triple().

    I think the patch is OK with that change. Nick, can you just comment
    on lib/Target/SubtargetFeature.cpp being the right place to put this?
    I think it is, but I am not as familiar with this code.


  I'm not familiar with most of lib/Target or lib/CodeGen either, but after reading through SubtargetFeature.{cpp,h} it looks like the right place to me.

  Nick
   

    > The attached patch has similar OS and Vendor independent re-factoring for Subtarget features (attributes).
    >
    > I moved Applce-specific code from tools/lto/LTOModule.cpp to lib/Target/SubtargetFeature.cpp with related header files update.
    >
    > Cheers,
    > Viktor.
    >


    Cheers,

    --
    Rafael Ávila de Espíndola


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091118/d701df58/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-lto-codegen-subtargetfeature-extended_functionality.diff
Type: application/octet-stream
Size: 4436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091118/d701df58/attachment.obj>