<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META content="text/html; charset=iso-8859-1" http-equiv=Content-Type>
<META name=GENERATOR content="MSHTML 8.00.6001.18828">
<STYLE></STYLE>
</HEAD>
<BODY bgColor=#ffffff>
<DIV><FONT size=2 face=Arial>Thanks, Nick and Rafael!</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>> Two t's in formatted.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT><FONT size=2 face=Arial></FONT><FONT size=2
face=Arial></FONT><BR><FONT size=2 face=Arial>Fixed.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>>> You have to change the .c_str() to
llvm::Triple().</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Fixed.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Patch is committed.</FONT></DIV>
<DIV><A
href="http://llvm.org/viewvc/llvm-project?rev=89236&view=rev">http://llvm.org/viewvc/llvm-project?rev=89236&view=rev</A></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>And while we are all on it, here is the next patch
in this sequence (please find it attached).</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>This patch adds two SubtargetFeatures::AddFeatures
methods which accept a comma-separated string or already parsed command line
parameters as input, SubtargetFeatures::hasFeature method which cheks if
given feature is already set, and some code re-factoring to use these new
methods.</FONT></DIV>
<DIV><FONT size=2 face=Arial></FONT> </DIV>
<DIV><FONT size=2 face=Arial>Best regards,<BR>Viktor<BR></FONT></DIV>
<BLOCKQUOTE
style="BORDER-LEFT: #000000 2px solid; PADDING-LEFT: 5px; PADDING-RIGHT: 0px; MARGIN-LEFT: 5px; MARGIN-RIGHT: 0px">
<DIV style="FONT: 10pt arial">----- Original Message ----- </DIV>
<DIV
style="FONT: 10pt arial; BACKGROUND: #e4e4e4; font-color: black"><B>From:</B>
<A title=nlewycky@google.com href="mailto:nlewycky@google.com">Nick
Lewycky</A> </DIV>
<DIV style="FONT: 10pt arial"><B>To:</B> <A title=espindola@google.com
href="mailto:espindola@google.com">Rafael Espindola</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Cc:</B> <A title=vkutuzov@accesssoftek.com
href="mailto:vkutuzov@accesssoftek.com">Viktor Kutuzov</A> ; <A
title=llvm-commits@cs.uiuc.edu href="mailto:llvm-commits@cs.uiuc.edu">Commit
Messages and Patches for LLVM</A> </DIV>
<DIV style="FONT: 10pt arial"><B>Sent:</B> Wednesday, November 18, 2009 10:34
AM</DIV>
<DIV style="FONT: 10pt arial"><B>Subject:</B> Re: [llvm-commits] [PATCH] LTO
code generator options</DIV>
<DIV><BR></DIV>
<DIV class=gmail_quote>+ /// Retrieve a formated string of the default
features for<BR>+ /// the specified target triple.<BR>+ static
std::string getDefaultSubtargetFeatures(const Triple &Triple);<BR><BR>Two
t's in formatted.<BR><BR>2009/11/18 Rafael Espindola <SPAN dir=ltr><<A
href="mailto:espindola@google.com">espindola@google.com</A>></SPAN><BR>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>2009/11/17 Viktor Kutuzov <<A
href="mailto:vkutuzov@accesssoftek.com">vkutuzov@accesssoftek.com</A>>:<BR>
<DIV class=im>> Thanks for reviewing it, Rafael.<BR>><BR>> Now
while we are both on the same waive, let's go with the rest of the
patches.<BR><BR></DIV>Have you committed the previous one?<BR>
<DIV class=im><BR>> I have tried to combine them on the same manner as
the last one.<BR><BR></DIV>Thanks!<BR><BR>You have<BR><BR>+
const std::string FeatureStr =<BR>+
SubtargetFeatures::getDefaultSubtargetFeatures(Triple.c_str());<BR><BR>But
getDefaultSubtargetFeatures takes a triple. You have to change
the<BR>.c_str() to llvm::Triple().<BR><BR>I think the patch is OK with that
change. Nick, can you just comment<BR>on lib/Target/SubtargetFeature.cpp
being the right place to put this?<BR>I think it is, but I am not as
familiar with this code.<BR></BLOCKQUOTE>
<DIV><BR>I'm not familiar with most of lib/Target or lib/CodeGen either, but
after reading through SubtargetFeature.{cpp,h} it looks like the right place
to me.<BR><BR>Nick<BR> </DIV>
<BLOCKQUOTE
style="BORDER-LEFT: rgb(204,204,204) 1px solid; MARGIN: 0pt 0pt 0pt 0.8ex; PADDING-LEFT: 1ex"
class=gmail_quote>
<DIV class=im><BR>> The attached patch has similar OS and Vendor
independent re-factoring for Subtarget features
(attributes).<BR>><BR>> I moved Applce-specific code from
tools/lto/LTOModule.cpp to lib/Target/SubtargetFeature.cpp with related
header files update.<BR>><BR>> Cheers,<BR>>
Viktor.<BR>><BR><BR></DIV>
<DIV>
<DIV></DIV>
<DIV class=h5>Cheers,<BR><BR>--<BR>Rafael Ávila de
Espíndola<BR></DIV></DIV></BLOCKQUOTE></DIV><BR></BLOCKQUOTE></BODY></HTML>