[llvm-commits] [PATCH] LTO code generator options

[Viktor Kutuzov]

Thanks for the review, Rafael.
I appreciate that you did it even with all those cosmetic changes there.
Sorry for the white spaces in that patch. I'll keep it separate from now on.

The updated patch is attached.

* StringRef is passed by value;
* Removed getArchNameForLLVMArchType;
* Fixed strange alignment.
* Removed all cosmetic changes from this patch.

Is it Ok to submit?

Cheers,
Viktor

----- Original Message ----- 
From: "Rafael Espindola" <espindola at google.com>
To: "Viktor Kutuzov" <vkutuzov at accesssoftek.com>
Cc: "Commit Messages and Patches for LLVM" <llvm-commits at cs.uiuc.edu>
Sent: Tuesday, November 10, 2009 4:25 PM
Subject: Re: [llvm-commits] [PATCH] LTO code generator options


> 2009/11/10 Viktor Kutuzov <vkutuzov at accesssoftek.com>:
>> Is this Ok to submit?
>
> Small comments:
>
> * StringRef is normally passed by value.
> * Can you put the header reordering and white space in an independent patch?
> * Part of the alignment looks strange:
> +        if (!MAttrs.empty())
> +               features.AddFeatures(MAttrs);
> * getArchNameForLLVMArchType is not used
>
>> Best regards,
>> Viktor
>
> Cheers,
> -- 
> Rafael Ávila de Espíndola
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm-lto-codegen-target_override-02.diff
Type: application/octet-stream
Size: 22783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20091111/529ef66c/attachment.obj>