[llvm-commits] [PATCH] LTO code generator options
Rafael Espindola
espindola at google.com
Tue Nov 10 16:25:45 PST 2009
2009/11/10 Viktor Kutuzov <vkutuzov at accesssoftek.com>:
> Is this Ok to submit?
Small comments:
* StringRef is normally passed by value.
* Can you put the header reordering and white space in an independent patch?
* Part of the alignment looks strange:
+ if (!MAttrs.empty())
+ features.AddFeatures(MAttrs);
* getArchNameForLLVMArchType is not used
> Best regards,
> Viktor
Cheers,
--
Rafael Ávila de Espíndola
More information about the llvm-commits
mailing list