[llvm-commits] [llvm] r84199 - in /llvm/trunk: include/llvm/Analysis/MallocHelper.h lib/Analysis/MallocHelper.cpp lib/Analysis/PointerTracking.cpp lib/Transforms/IPO/GlobalOpt.cpp

[Victor Hernandez]

Duncan,

You are correct.  Will fix that immediately.  And add the test case to  
make sure I didn't mess it up again.

Victor

On Oct 16, 2009, at 12:12 AM, Duncan Sands wrote:

> Hi Victor,
>
>> Value* llvm::getMallocArraySize(CallInst* CI, LLVMContext &Context,
>>                                const TargetData* TD) {
>> +  if (isSafeToGetMallocArraySize(CI, Context, TD))
>> +    return NULL;
>
> looks like the check is inverted here: shouldn't you be returning
> NULL is it isn't safe, not if it is safe?
>
> Ciao,
>
> Duncan.