[llvm-commits] [llvm] r84199 - in /llvm/trunk: include/llvm/Analysis/MallocHelper.h lib/Analysis/MallocHelper.cpp lib/Analysis/PointerTracking.cpp lib/Transforms/IPO/GlobalOpt.cpp

Duncan Sands baldrick at free.fr
Fri Oct 16 00:12:35 PDT 2009


Hi Victor,

>  Value* llvm::getMallocArraySize(CallInst* CI, LLVMContext &Context,
>                                  const TargetData* TD) {
> +  if (isSafeToGetMallocArraySize(CI, Context, TD))
> +    return NULL;

looks like the check is inverted here: shouldn't you be returning
NULL is it isn't safe, not if it is safe?

Ciao,

Duncan.



More information about the llvm-commits mailing list