[llvm-commits] REQUIRES_FP in Makefile.rules

[Nicolas Geoffray]

Eric Christopher wrote:
>>
>>
>>
>> vmkit method (start_thread)
>> Java method
>> Java method
>> Java method
>> LLVM callback for lazy compilation
>> LLVM JIT emitter
>> ModuleProvider::materializeFunction
>> vmkit method
>> vmkit method (<--- safe point entered here)
>>
>>
>> I hope the example is clear.
>
> It is, perhaps that's a bad point to have as a safe point?

No because, vmkit methods may be interblocked with each other 
(materializing a function takes locks), and if a thread that owns a lock 
joins the collection, another thread that wants to take the lock must 
also be able to join the collection.

>
> At any rate, I'm not against the option in general so feel free to 
> commit :)
>

Yes, just did. Thanks!

Nicolas