[llvm-commits] REQUIRES_FP in Makefile.rules

[Dale Johannesen]

On Aug 18, 2009, at 3:36 PMPDT, Nicolas Geoffray wrote:

> Hi all,
>
> I'd like to add a new option (REQUIRES_FP) in Makefile.rules to  
> disable the fomit-frame-pointer option when building. Here's the  
> patch attached. I need this because vmkit needs to walk the stack of  
> a thread, and functions from llvm may be in it.

I suggest you name it something that doesn't look like Floating Point.

> I don't know what's the policy for the Makefiles in general. Is it  
> OK to apply that change?
>
> Thanks,
> Nicolas
> Index: Makefile.rules
> ===================================================================
> --- Makefile.rules	(revision 79109)
> +++ Makefile.rules	(working copy)
> @@ -337,6 +337,12 @@
>   CXX.Flags += -fno-exceptions
> endif
>
> +ifdef REQUIRES_FP
> +  CXX.Flags := $(filter-out -fomit-frame-pointer,$(CXX.Flags))
> +  C.Flags   := $(filter-out -fomit-frame-pointer,$(C.Flags))
> +  LD.Flags  := $(filter-out -fomit-frame-pointer,$(LD.Flags))
> +endif
> +
> # IF REQUIRES_RTTI=1 is specified then don't disable run-time type id
> ifndef REQUIRES_RTTI
> #  CXX.Flags += -fno-rtti
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits