[llvm-commits] [PATCH] Dump with LI Indices

[Chris Lattner]

On Aug 5, 2009, at 1:20 PM, David Greene wrote:

> On Tuesday 04 August 2009 23:07, Chris Lattner wrote:
>
>> The idea is that we shouldn't have to affect every instance of "dump
>> ()", just add a new DumpWithLiveIntervals() function, and call that
>> instead.  There is no reason to have "magic" to make "dump()" itself
>> add extra info.
>
> I still don't understand how this is better.  Wouldn't  
> DumpWithLiveIntervals()
> have to duplicate all of the functionality of dump()?

Yes.  It is better because live-intervals specific code is specific to  
live intervals.  The code to loop over the mbbs and instructions in an  
mbb is only a few lines.

-Chris