[llvm-commits] [llvm] r78048 - in /llvm/trunk: include/llvm/Value.h include/llvm/ValueSymbolTable.h lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/Value.cpp

[Chris Lattner]

On Aug 4, 2009, at 3:29 PM, Dan Gohman wrote:
> On Aug 3, 2009, at 9:31 PM, Chris Lattner wrote:
>> Author: lattner
>> Date: Mon Aug  3 23:31:02 2009
>> New Revision: 78048
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=78048&view=rev
>> Log:
>> switch ValueMap to using AssertingVH.  This is an old patch I had
>> laying
>> around in a tree I forgot about.
>
> Hi Chris,
>
> This has the property of causing LLVM's public ABI to be non-trivially
> sensitive to NDEBUG. If clients aren't built with NDEBUG set to what
> it's set to in the LLVM build they're linking with, the results are
> very bad and very hard to diagnose. I think this is too heavy a
> burden to put on clients.

I'm not really very sympathetic to that... there are so many ways that  
people will already get burned if they do that, it isn't funny.  Also,  
the build system splits out assert and non-assert builds, so it is  
unlikely to happen.  However, I don't really have a strong opinion and  
don't think it adds much value, so I reverted it.

-Chris