[llvm-commits] [llvm] r78048 - in /llvm/trunk: include/llvm/Value.h include/llvm/ValueSymbolTable.h lib/Bitcode/Writer/BitcodeWriter.cpp lib/VMCore/Value.cpp

[Dan Gohman]

On Aug 3, 2009, at 9:31 PM, Chris Lattner wrote:


> Author: lattner
> Date: Mon Aug  3 23:31:02 2009
> New Revision: 78048
>
> URL: http://llvm.org/viewvc/llvm-project?rev=78048&view=rev
> Log:
> switch ValueMap to using AssertingVH.  This is an old patch I had  
> laying
> around in a tree I forgot about.

Hi Chris,

This has the property of causing LLVM's public ABI to be non-trivially
sensitive to NDEBUG. If clients aren't built with NDEBUG set to what
it's set to in the LLVM build they're linking with, the results are
very bad and very hard to diagnose. I think this is too heavy a
burden to put on clients.

Dan