[llvm-commits] [llvm] r75806 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h utils/TableGen/AsmWriterEmitter.cpp

[David A. Greene]

On Friday 17 July 2009 12:26, you wrote:
> >       // Do the post instruction processing and print the final newline
> > -      UniqueOperandCommands.push_back("    postInstructionAction(*MI);\n
> >    O << \"\\n\";\n    return true;\n"); +     
> > UniqueOperandCommands.push_back("    EmitComments(*MI);\n    O <<
> > \"\\n\";\n    return true;\n");
>
> This "return true" here is too early, it is missing the last fragment in
> case of MOVF_INSN in PIC16. I think this is broken since your commit
> 75490 itself.

Strange that testing didn't catch this.

> (ins i8imm:$offset, i8mem:$ptrlo, i8imm:$ptrhi),
>              "movf ${ptrlo} + ${offset}, W",
>
> ", W"    is getting missed.
> Try attached .bc file.

Ok, I'll look at this.

                                   -Dave