[llvm-commits] [llvm] r75806 - in /llvm/trunk: include/llvm/CodeGen/AsmPrinter.h utils/TableGen/AsmWriterEmitter.cpp

[Sanjiv Gupta]

>       // Do the post instruction processing and print the final newline
> -      UniqueOperandCommands.push_back("    postInstructionAction(*MI);\n    O << \"\\n\";\n    return true;\n");
> +      UniqueOperandCommands.push_back("    EmitComments(*MI);\n    O << \"\\n\";\n    return true;\n");
>   
This "return true" here is too early, it is missing the last fragment in 
case of MOVF_INSN in PIC16. I think this is broken since your commit 
75490 itself.

(ins i8imm:$offset, i8mem:$ptrlo, i8imm:$ptrhi),
             "movf ${ptrlo} + ${offset}, W",

", W"    is getting missed.
Try attached .bc file.

- Sanjiv

>        isFirst = false;
>      }
>  
> @@ -745,7 +745,7 @@
>        EmitInstructions(Instructions, O);
>  
>      O << "  }\n";
> -    O << "  postInstructionAction(*MI);\n";
> +    O << "  EmitComments(*MI);\n";
>      // Print the final newline
>      O << "  O << \"\\n\";\n";
>      O << "  return true;\n";
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: add_neg.bc
Type: application/octet-stream
Size: 504 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090717/3d07f596/attachment.obj>