[llvm-commits] [llvm] r74150 - in /llvm/trunk: lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp lib/Target/Mi
Nick Lewycky
nlewycky at google.com
Wed Jun 24 18:14:36 PDT 2009
2009/6/24 Devang Patel <dpatel at apple.com>
> Author: dpatel
> Date: Wed Jun 24 19:47:42 2009
> New Revision: 74150
>
> URL: http://llvm.org/viewvc/llvm-project?rev=74150&view=rev
> Log:
>
> No need to code gen MDNodes
Hi Devang, thanks for working on this!
We probably also don't want to codegen MDStrings either.
Nick
Added:
> llvm/trunk/test/Feature/mdnode.ll
> Modified:
> llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
> llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp
> llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp
> llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp
> llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp
> llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
> llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp
> llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -21,6 +21,7 @@
> #include "ARMMachineFunctionInfo.h"
> #include "llvm/Constants.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> #include "llvm/CodeGen/MachineModuleInfo.h"
> @@ -923,6 +924,8 @@
>
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> const Type *Type = C->getType();
> unsigned Size = TD->getTypeAllocSize(Type);
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
> Modified: llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -17,6 +17,7 @@
> #include "AlphaInstrInfo.h"
> #include "AlphaTargetMachine.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/Type.h"
> #include "llvm/Assembly/Writer.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> @@ -222,6 +223,8 @@
>
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> unsigned Size = TD->getTypeAllocSize(C->getType());
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
>
> Modified: llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -19,6 +19,7 @@
> #include "llvm/Constants.h"
> #include "llvm/DerivedTypes.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/Assembly/Writer.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> @@ -521,6 +522,8 @@
> printVisibility(name, GVar->getVisibility());
>
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> const Type *Type = C->getType();
> unsigned Size = TD->getTypeAllocSize(Type);
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
> Modified: llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -20,6 +20,7 @@
> #include "IA64.h"
> #include "IA64TargetMachine.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/Type.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> @@ -269,6 +270,8 @@
> O << "\n\n";
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> unsigned Size = TD->getTypeAllocSize(C->getType());
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
>
> Modified: llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -22,6 +22,7 @@
> #include "llvm/Constants.h"
> #include "llvm/DerivedTypes.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> #include "llvm/CodeGen/MachineFunctionPass.h"
> @@ -483,6 +484,8 @@
> O << "\n\n";
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> const Type *CTy = C->getType();
> unsigned Size = TD->getTypeAllocSize(CTy);
> const ConstantArray *CVA = dyn_cast<ConstantArray>(C);
>
> Modified: llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -24,6 +24,7 @@
> #include "llvm/Constants.h"
> #include "llvm/DerivedTypes.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/Assembly/Writer.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> @@ -656,6 +657,8 @@
> printVisibility(name, GVar->getVisibility());
>
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> const Type *Type = C->getType();
> unsigned Size = TD->getTypeAllocSize(Type);
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
> Modified: llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -19,6 +19,7 @@
> #include "llvm/Constants.h"
> #include "llvm/DerivedTypes.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/CodeGen/AsmPrinter.h"
> #include "llvm/CodeGen/DwarfWriter.h"
> #include "llvm/CodeGen/MachineFunctionPass.h"
> @@ -253,6 +254,8 @@
> O << "\n\n";
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> unsigned Size = TD->getTypeAllocSize(C->getType());
> unsigned Align = TD->getPreferredAlignment(GVar);
>
>
> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff
>
>
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp Wed Jun 24
> 19:47:42 2009
> @@ -23,6 +23,7 @@
> #include "llvm/CallingConv.h"
> #include "llvm/DerivedTypes.h"
> #include "llvm/Module.h"
> +#include "llvm/MDNode.h"
> #include "llvm/Type.h"
> #include "llvm/ADT/Statistic.h"
> #include "llvm/ADT/StringExtras.h"
> @@ -974,6 +975,8 @@
>
> std::string name = Mang->getValueName(GVar);
> Constant *C = GVar->getInitializer();
> + if (isa<MDNode>(C))
> + return;
> const Type *Type = C->getType();
> unsigned Size = TD->getTypeAllocSize(Type);
> unsigned Align = TD->getPreferredAlignmentLog(GVar);
>
> Added: llvm/trunk/test/Feature/mdnode.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/mdnode.ll?rev=74150&view=auto
>
>
> ==============================================================================
> --- llvm/trunk/test/Feature/mdnode.ll (added)
> +++ llvm/trunk/test/Feature/mdnode.ll Wed Jun 24 19:47:42 2009
> @@ -0,0 +1,2 @@
> +; RUN: llvm-as < %s | llc -f -o /dev/null
> + at llvm.foo = constant metadata !{i17 123, null, metadata !"foobar"}
> \ No newline at end of file
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20090624/bad50463/attachment.html>
More information about the llvm-commits
mailing list