<div class="gmail_quote">2009/6/24 Devang Patel <span dir="ltr"><<a href="mailto:dpatel@apple.com">dpatel@apple.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

Author: dpatel<br>
Date: Wed Jun 24 19:47:42 2009<br>
New Revision: 74150<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=74150&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=74150&view=rev</a><br>
Log:<br>
<br>
No need to code gen MDNodes</blockquote><div><br></div><div>Hi Devang, thanks for working on this!</div><div><br></div><div>We probably also don't want to codegen MDStrings either.</div><div><br></div><div>Nick</div>

<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Added:<br>
    llvm/trunk/test/Feature/mdnode.ll<br>
Modified:<br>
    llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp<br>
    llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp<br>
    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -21,6 +21,7 @@<br>
 #include "ARMMachineFunctionInfo.h"<br>
 #include "llvm/Constants.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
 #include "llvm/CodeGen/MachineModuleInfo.h"<br>
@@ -923,6 +924,8 @@<br>
<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   const Type *Type = C->getType();<br>
   unsigned Size = TD->getTypeAllocSize(Type);<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
Modified: llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/Alpha/AsmPrinter/AlphaAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -17,6 +17,7 @@<br>
 #include "AlphaInstrInfo.h"<br>
 #include "AlphaTargetMachine.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/Type.h"<br>
 #include "llvm/Assembly/Writer.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
@@ -222,6 +223,8 @@<br>
<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   unsigned Size = TD->getTypeAllocSize(C->getType());<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
<br>
Modified: llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/CellSPU/AsmPrinter/SPUAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -19,6 +19,7 @@<br>
 #include "llvm/Constants.h"<br>
 #include "llvm/DerivedTypes.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/Assembly/Writer.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
@@ -521,6 +522,8 @@<br>
   printVisibility(name, GVar->getVisibility());<br>
<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   const Type *Type = C->getType();<br>
   unsigned Size = TD->getTypeAllocSize(Type);<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
Modified: llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/IA64/AsmPrinter/IA64AsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -20,6 +20,7 @@<br>
 #include "IA64.h"<br>
 #include "IA64TargetMachine.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/Type.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
@@ -269,6 +270,8 @@<br>
   O << "\n\n";<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   unsigned Size = TD->getTypeAllocSize(C->getType());<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
<br>
Modified: llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/Mips/AsmPrinter/MipsAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -22,6 +22,7 @@<br>
 #include "llvm/Constants.h"<br>
 #include "llvm/DerivedTypes.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
 #include "llvm/CodeGen/MachineFunctionPass.h"<br>
@@ -483,6 +484,8 @@<br>
   O << "\n\n";<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   const Type *CTy = C->getType();<br>
   unsigned Size = TD->getTypeAllocSize(CTy);<br>
   const ConstantArray *CVA = dyn_cast<ConstantArray>(C);<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/AsmPrinter/PPCAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -24,6 +24,7 @@<br>
 #include "llvm/Constants.h"<br>
 #include "llvm/DerivedTypes.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/Assembly/Writer.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
@@ -656,6 +657,8 @@<br>
   printVisibility(name, GVar->getVisibility());<br>
<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   const Type *Type = C->getType();<br>
   unsigned Size = TD->getTypeAllocSize(Type);<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
Modified: llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/Sparc/AsmPrinter/SparcAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -19,6 +19,7 @@<br>
 #include "llvm/Constants.h"<br>
 #include "llvm/DerivedTypes.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/CodeGen/AsmPrinter.h"<br>
 #include "llvm/CodeGen/DwarfWriter.h"<br>
 #include "llvm/CodeGen/MachineFunctionPass.h"<br>
@@ -253,6 +254,8 @@<br>
   O << "\n\n";<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   unsigned Size = TD->getTypeAllocSize(C->getType());<br>
   unsigned Align = TD->getPreferredAlignment(GVar);<br>
<br>
<br>
Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp?rev=74150&r1=74149&r2=74150&view=diff</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTAsmPrinter.cpp Wed Jun 24 19:47:42 2009<br>
@@ -23,6 +23,7 @@<br>
 #include "llvm/CallingConv.h"<br>
 #include "llvm/DerivedTypes.h"<br>
 #include "llvm/Module.h"<br>
+#include "llvm/MDNode.h"<br>
 #include "llvm/Type.h"<br>
 #include "llvm/ADT/Statistic.h"<br>
 #include "llvm/ADT/StringExtras.h"<br>
@@ -974,6 +975,8 @@<br>
<br>
   std::string name = Mang->getValueName(GVar);<br>
   Constant *C = GVar->getInitializer();<br>
+  if (isa<MDNode>(C))<br>
+    return;<br>
   const Type *Type = C->getType();<br>
   unsigned Size = TD->getTypeAllocSize(Type);<br>
   unsigned Align = TD->getPreferredAlignmentLog(GVar);<br>
<br>
Added: llvm/trunk/test/Feature/mdnode.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/mdnode.ll?rev=74150&view=auto" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/mdnode.ll?rev=74150&view=auto</a><br>


<br>
==============================================================================<br>
--- llvm/trunk/test/Feature/mdnode.ll (added)<br>
+++ llvm/trunk/test/Feature/mdnode.ll Wed Jun 24 19:47:42 2009<br>
@@ -0,0 +1,2 @@<br>
+; RUN: llvm-as < %s | llc -f -o /dev/null<br>
+@llvm.foo =  constant metadata !{i17 123, null, metadata !"foobar"}<br>
\ No newline at end of file<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>