[llvm-commits] [llvm] r68610 - /llvm/trunk/include/llvm/Bitcode/BitstreamWriter.h

[Chris Lattner]

On Apr 8, 2009, at 11:46 AM, Dan Gohman wrote:
> Has someone spent too much time micro-optimizing C front-end code? ;-)
> CHAR_BIT just requires <limits.h>, and it makes it more obvious
> that the code is talking about a byte on the host.

Bitstream stuff (as well as llvm in general) already makes many many  
assumptions that there are 8 bits in a host byte.

-Chris

>
>
> Dan
>
> On Apr 8, 2009, at 9:52 AM, Chris Lattner wrote:
>
>> Doug, can you just use 8 instead of CHAR_BIT?
>>
>> On Apr 8, 2009, at 9:42 AM, Preston Gurd wrote:
>>
>>> This patch breaks my build, because CHAR_BIT is undefined.
>>>
>>> Surely the patch must also add an include of <limits.h> to obtain  
>>> the
>>> definition of CHAR_BIT?
>>>
>>>
>>>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits