[llvm-commits] [llvm] r68610 - /llvm/trunk/include/llvm/Bitcode/BitstreamWriter.h

Dan Gohman gohman at apple.com
Wed Apr 8 11:46:28 PDT 2009


Has someone spent too much time micro-optimizing C front-end code? ;-)
CHAR_BIT just requires <limits.h>, and it makes it more obvious
that the code is talking about a byte on the host.

Dan

On Apr 8, 2009, at 9:52 AM, Chris Lattner wrote:

> Doug, can you just use 8 instead of CHAR_BIT?
>
> On Apr 8, 2009, at 9:42 AM, Preston Gurd wrote:
>
>> This patch breaks my build, because CHAR_BIT is undefined.
>>
>> Surely the patch must also add an include of <limits.h> to obtain the
>> definition of CHAR_BIT?
>>
>>
>>



More information about the llvm-commits mailing list