[llvm-commits] [llvm-gcc-4.2] r65490 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp
Anton Korobeynikov
anton at korobeynikov.info
Thu Feb 26 10:38:01 PST 2009
Hi, Chris
> If it is a semantic requirement, then I think the IR should capture
> this requirement.
Ok, this makes sense.
> Does this approach make sense to you? FWIW, they already fixed the
> backend to "do the right thing",
I know :) I did this someday.
> so this is fixing a "theoretical" or "purity" issue.
From this point of view the patch is not complete, as you already
mentioned, it does not "capture" zero-sized strings.
Stuart, the "full" check can be see seen in lib/Target/
TargetAsmInfo.cpp:isConstantString()
---
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University
More information about the llvm-commits
mailing list