[llvm-commits] [llvm-gcc-4.2] r65490 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Chris Lattner]

On Feb 26, 2009, at 12:20 AM, Anton Korobeynikov wrote:

>
>> Put all normal (no embedded NUL characters), constant STRING_CSTs in
>> the .cstring section.
> Please don't do that. The backend should decide, whether to put such
> stuff, *especially* in such easy situations.

Anton, I generally agree, but not in this case.  Here the linker  
*requires* certain strings to be in the cstring section.  When it is a  
question of a missed optimization, I think the backend should be  
trusted to do the right thing.  If it is a semantic requirement, then  
I think the IR should capture this requirement.

Does this approach make sense to you?  FWIW, they already fixed the  
backend to "do the right thing", so this is fixing a "theoretical" or  
"purity" issue.

-Chris