[llvm-commits] [llvm] r64369 - in /llvm/trunk: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp test/CodeGen/ARM/2008-11-19-ScavengerAssert.ll test/CodeGen/X86/2008-08-05-SpillerBug.ll

[Evan Cheng]

On Feb 12, 2009, at 2:05 PM, Dan Gohman wrote:

>>
>> =
>> =====================================================================
>> --- llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
>> (original)
>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp Thu
>> Feb 12 02:59:45 2009
>> @@ -916,7 +916,7 @@
>>    if (PredSethiUllman > SethiUllmanNumber) {
>>      SethiUllmanNumber = PredSethiUllman;
>>      Extra = 0;
>> -    } else if (PredSethiUllman == SethiUllmanNumber && !I->isCtrl())
>> +    } else if (PredSethiUllman == SethiUllmanNumber)
>>      ++Extra;
>>  }
>
> Hi Evan, this change doesn't seem to be related to the other changes.
> What is
> it for?  Control edges don't correspond to registers, so why should
> they be
> counted in the sethi-ullman number?

That's just a redundant check. There was this "    if (I->isCtrl())  
continue;  // ignore chain preds" earlier.

Evan

>
>
> Dan
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits