[llvm-commits] [llvm] r64369 - in /llvm/trunk: lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp test/CodeGen/ARM/2008-11-19-ScavengerAssert.ll test/CodeGen/X86/2008-08-05-SpillerBug.ll

[Dan Gohman]

On Feb 12, 2009, at 12:59 AM, Evan Cheng wrote:

> Author: evancheng
> Date: Thu Feb 12 02:59:45 2009
> New Revision: 64369
>
> URL: http://llvm.org/viewvc/llvm-project?rev=64369&view=rev
> Log:
> Replace one of burr scheduling heuristic with something more  
> sensible. Now calcMaxScratches simply compute the number of true  
> data dependencies. This actually improve a couple of tests in  
> dejagnu suite as many tests in llvm nightly test suite.
>
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
>    llvm/trunk/test/CodeGen/ARM/2008-11-19-ScavengerAssert.ll
>    llvm/trunk/test/CodeGen/X86/2008-08-05-SpillerBug.ll
>
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp?rev=64369&r1=64368&r2=64369&view=diff
>
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> = 
> ======================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp  
> (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp Thu  
> Feb 12 02:59:45 2009
> @@ -916,7 +916,7 @@
>     if (PredSethiUllman > SethiUllmanNumber) {
>       SethiUllmanNumber = PredSethiUllman;
>       Extra = 0;
> -    } else if (PredSethiUllman == SethiUllmanNumber && !I->isCtrl())
> +    } else if (PredSethiUllman == SethiUllmanNumber)
>       ++Extra;
>   }

Hi Evan, this change doesn't seem to be related to the other changes.  
What is
it for?  Control edges don't correspond to registers, so why should  
they be
counted in the sethi-ullman number?

Dan